chore: remove unused code #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update dev installation starting rest server * Update db name anyvar_db --> anyvar
…into hackathon-2023
close #51 If memory serves, this was originally part of AnyVar, and I tore it out in favor of the VICC Variation Translator. This PR adds it back in as the default translator layer. The only data dependency is a SeqRepo instance -- I think it makes sense to fall back on the VRS-Python create_dataproxy function and use the same URI schema that it prefers, but set it from the SEQREPO_DATAPROXY_URI variable and use REST service on localhost port 5000 by default (rather than erroring if it's unset)
…ommons template (#58)
* Removed clinvarparser, variation normalizer rest translator, digest, formats, + ordered enum * Removed DEFAULT_TRANSLATE_URI
jsstevenson
previously approved these changes
Oct 9, 2023
There was a problem hiding this comment.
👍
there is... a view of AnyVar where the VICC normalizer is a first-class citizen, so I think we should be sure to maintain the translate interface abstraction (rather than becoming too intertwined with VRS-Python specifically) but I'm happy to not worry too much about the normalizer backend for now
jsstevenson
approved these changes
Oct 13, 2023
This was referenced Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused code. We can add things back in the future if needed
Notes: