Support for Specification Extensions #11 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenAPI Info Contact License Server ServerVariable PathItem Operation RequestBody MediaType Encoding Example Link Response Tag
Merge biocad/openapi3
ExternalDocumentation Responses Schema XML Security Scheme OAUTH Flows OAUTH Flow
|
Hi! Can you please merge master to your branch, so that there are no conflicts? |
|
Sure, Will send in updated one |
ExternalDocumentation Responses Schema XML Security Scheme OAUTH Flows OAUTH Flow
Compiles with 9.2 now
maksbotan
reviewed
Nov 19, 2022
| @@ -412,7 +412,6 @@ import Data.OpenApi.Internal | |||
| -- ], | |||
| -- "type": "object" | |||
| -- } | |||
|
|
|||
There was a problem hiding this comment.
this empty line is crucial, it separates a new section "manipulation" from the previous one. please bring it back :)
| @@ -184,7 +185,6 @@ import Data.OpenApi.Internal | |||
| -- "title": "Todo API", | |||
| -- "version": "1.0" | |||
| -- } | |||
|
|
|||
| in pairs (pairsToSeries (opts ^. saoAdditionalPairs) <> ps) | ||
| where | ||
| proxy = Proxy :: Proxy a | ||
| defs = hcpure (Proxy :: Proxy AesonDefaultValue) defaultValue |
There was a problem hiding this comment.
why is this different from (aesonDefaults proxy) in sopSwaggerGenericToEncoding?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11