Remove duplicated in/out-...-E/V methods from the TypedGraph #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in TypedVertex); in/out-Many is removed completely as a duplicate of general in/out-E/V
laughedelic
added
2 - in progress
3 - needs review
and removed
1 - planned
2 - in progress
labels
|
It's not that simple :) this deserves a chat |
|
Ok. Let's discuss it in gitter? What's that about? |
|
This is done in #58. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All these in/out-One/Optional/Many-E/V methods in the
TypedGraphhave default implementations, based on the general in/out-E/V ones (by the way,outManyEis just the same asoutE).I'm going to leave in the
TypedGraphonly in/out-E/V and move implementations of the rest of them to theTypedVertex(where they also have default implementations based on these graph ones). From the point of view of the API, you're going to use these things from a vertex, not the graph.