Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ListSessions of BGP API #271

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sebageek
Copy link
Contributor

VRF filtering and some session stats are still missing here, but listing
sessions does work.


I'm not 100% on what I should fill in into the SessionStat, that's why I only filled them partly.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2020

Codecov Report

Merging #271 into master will increase coverage by 0.35%.
The diff coverage is 91.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   59.25%   59.60%   +0.35%     
==========================================
  Files         137      137              
  Lines        7542     7588      +46     
==========================================
+ Hits         4469     4523      +54     
+ Misses       2892     2882      -10     
- Partials      181      183       +2     
Impacted Files Coverage Δ
protocols/bgp/server/bgp_api.go 78.94% <91.48%> (+25.61%) ⬆️
protocols/bgp/server/metrics_service.go 100.00% <0.00%> (+1.75%) ⬆️
protocols/bgp/server/server.go 25.19% <0.00%> (+7.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52c6591...855dbd4. Read the comment docs.

@sebageek
Copy link
Contributor Author

From a quick look it should also be easy to get RoutesImported and RoutesExported from the metrics service. I'll add this to this PR tomorrow.

@sebageek sebageek marked this pull request as draft May 24, 2020 01:53
@sebageek sebageek force-pushed the bgp-api-implement-listsessions branch 2 times, most recently from 7f74a99 to a1a2d12 Compare May 24, 2020 02:23
@sebageek sebageek marked this pull request as ready for review May 24, 2020 02:23
@sebageek sebageek force-pushed the bgp-api-implement-listsessions branch from a1a2d12 to c866150 Compare May 24, 2020 13:14
flaps + routes imported in the stats are still missing.
@sebageek sebageek force-pushed the bgp-api-implement-listsessions branch from c866150 to 855dbd4 Compare May 26, 2020 23:22
@sebageek
Copy link
Contributor Author

I added some stuff. The session API now has a vrf_name field, the description field is filled and vrf_name filtering is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants