Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow defining routingtable.ClientOptions from ObserveRIBRequest #466

Open
netixx opened this issue Apr 17, 2024 · 2 comments
Open

Allow defining routingtable.ClientOptions from ObserveRIBRequest #466

netixx opened this issue Apr 17, 2024 · 2 comments

Comments

@netixx
Copy link
Contributor

netixx commented Apr 17, 2024

Describe the feature
I would like to be able to specify options of the routingtable.ClientOptions when I do my ObserveRIB request, such as:

  • MaxPaths
  • EcmpOnly
  • BestOnly

This way the client can decide what type of paths it wants to receive.
Currently the options are hard-coded:

rib.RegisterWithOptions(rc, routingtable.ClientOptions{
		MaxPaths: 100,
	})

It would also be nice if we could specify those options for the DumpRIB request.

Use cases / additional context
I have a client that uses ObserveRIB to re-build a router RIB locally,
but I only need ECMP best paths, so I would like to be able to specify those options.

On other clients, we may want to get the full feed for observability purposes.

@taktv6
Copy link
Member

taktv6 commented Apr 18, 2024

I like the idea. Would definitely be willing to merge a PR that implements this. However, I won't find time to address this myself anytime soon.

netixx added a commit to netixx/bio-rd that referenced this issue Apr 18, 2024
Solves github.com/bio-routing/issues/466 for the ris server part.

Signed-off-by: netixx <[email protected]>
@netixx
Copy link
Contributor Author

netixx commented Apr 18, 2024

Ok, here I go :)

I handle to ObserveRIB part here, for the DumpRIB, it would need more work.

netixx added a commit to netixx/bio-rd that referenced this issue Apr 18, 2024
Solves github.com/bio-routing/issues/466 for the ris server part.

Signed-off-by: netixx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants