Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin numpy to versions below 1.14 #34

Closed
wants to merge 2 commits into from
Closed

Pin numpy to versions below 1.14 #34

wants to merge 2 commits into from

Conversation

mimischi
Copy link
Contributor

Changes made in this Pull Request:

That is the error that otherwise shows up everytime mdbenchmark is run:

$ mdbenchmark --version
/home/mischi/.local/lib/python3.6/site-packages/h5py/__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from `float` to `np.floating` is deprecated. In future, it will be treated as `np.float64 == np.dtype(float).type`.
  from ._conv import register_converters as _register_converters
mdbenchmark, version 1.1.1

PR Checklist

  • CHANGELOG updated (added news fragment into changelog directory)?
  • [ ] Issue raised/referenced?

@codecov
Copy link

codecov bot commented Feb 11, 2018

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   66.25%   66.25%           
=======================================
  Files          10       10           
  Lines         323      323           
=======================================
  Hits          214      214           
  Misses        109      109

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17513de...61299b1. Read the comment docs.

@kain88-de
Copy link
Contributor

Or much better just add a warnings filter. There is no reason to limit the numpy version installable on a system because of a warning that is thrown.

@mimischi mimischi mentioned this pull request Feb 13, 2018
1 task
@mimischi
Copy link
Contributor Author

Closing in favor of #35.

@mimischi mimischi closed this Feb 13, 2018
@mimischi mimischi deleted the numpy branch February 13, 2018 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants