Skip to content

Commit

Permalink
be case insensitive for module names
Browse files Browse the repository at this point in the history
fixes #61
  • Loading branch information
kain88-de committed May 16, 2018
1 parent 2caa3bd commit 5067952
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 10 deletions.
2 changes: 1 addition & 1 deletion mdbenchmark/mdengines/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def detect_md_engine(modulename):
"""

for name, engine in six.iteritems(SUPPORTED_ENGINES):
if name in modulename:
if name in modulename.lower():
return engine

return None
Expand Down
20 changes: 11 additions & 9 deletions mdbenchmark/tests/mdengines/test_init.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,16 +52,18 @@ def test_prepare_module_name(capsys):
assert prepare_module_name('gromacs/2016.4')


def test_detect_md_engine():
@pytest.mark.parametrize('arg, out',
(('gromacs/2016.3', 'mdbenchmark.mdengines.gromacs'),
('namd/123', 'mdbenchmark.mdengines.namd'),
('NAMD/123', 'mdbenchmark.mdengines.namd'),
('NamD/123', 'mdbenchmark.mdengines.namd'),
('GROMACS/123', 'mdbenchmark.mdengines.gromacs'),
('GRomacS/123', 'mdbenchmark.mdengines.gromacs'),
('someengine/123', None)))
def test_detect_md_engine(arg, out):
"""Test that we only accept supported MD engines."""

engine = detect_md_engine('gromacs/2016.3')
assert engine.__name__ == 'mdbenchmark.mdengines.gromacs'

engine = detect_md_engine('namd/123')
assert engine.__name__ == 'mdbenchmark.mdengines.namd'

assert detect_md_engine('someengine/123') is None
engine = detect_md_engine(arg)
assert engine.__name__ == out


def test_normalize_modules(capsys, monkeypatch, tmpdir):
Expand Down

0 comments on commit 5067952

Please sign in to comment.