Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated cfn-postgres provider with 1 new custom:: CFN policy #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vschurink
Copy link

also updated readme, added missing docs and cleaned up test code so testing can happen without hardcoded credentials.

@vschurink
Copy link
Author

Please note!

This is a BREAKING CHANGE!!!!
Please mark / tag is appropriately!!

this due to the reversal of the DeletionPolicy default.
Our decision / thought process was that it makes no sense to do 2 commits /deploys to drop anything in cloudformation.
If you want to keep it, set "DeletionPolicy: Retain" Otherwise it gets removed when you remove the object in cloudformation.

This prevents dangling / ghost resources that you might have to clean up manually later, and ensures that you mark everything you want to keep / safeguard appropriatly.

@mvanholsteijn mvanholsteijn force-pushed the master branch 2 times, most recently from cb26ea0 to b42fdc6 Compare July 4, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant