This repository has been archived by the owner on Mar 26, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er and develop Mostly to capture zaphoyd/websocketpp#814
jmarrec
added a commit
to NREL/OpenStudio
that referenced
this pull request
Dec 17, 2019
Croydon
reviewed
Dec 17, 2019
By the way, @uilianries is adding Boost 1.68 to CCI now assumingly because of websocketpp conan-io/conan-center-index#498 |
jmarrec
commented
Dec 17, 2019
|
||
def source(self): | ||
archive_name = "{0}-{1}".format(self.name, self.version) | ||
tools.get("{0}/archive/{1}.tar.gz".format(self.homepage, self.version), | ||
sha256="178899de48c02853b55b1ea8681599641cedcdfce59e56beaff3dd0874bf0286") | ||
os.rename(archive_name, self._source_subfolder) | ||
|
||
# Patch for boost 1.70+ support | ||
# TODO: will not be necessary anymore with websocket release > 0.8.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @Croydon. Do you happen to know when the next testing => stable merge will happen? |
Whenever we see it fit 😄 Done |
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending a new release of https://github.com/zaphoyd/websocketpp, add patch diffing between current websocket master and develop, mostly to capture zaphoyd/websocketpp#814 that enables support for boost 1.70+