Add portaudio v19.7.0 #1377
Add portaudio v19.7.0 #1377
Conversation
| @@ -14,27 +14,22 @@ class ConanRecipe(ConanFile): | |||
| "fPIC": [True, False], | |||
| "with_alsa": [True, False], | |||
| "with_jack": [True, False], | |||
| "cpp_bindings": [True, False], | |||
There was a problem hiding this comment.
Why did you delete this option? If was explicitly added in #1328
There was a problem hiding this comment.
cpp_bindings seems not supported in CMake for now(PortAudio/portaudio#539), so I removed it. if CMake is not good enough, I will change the recipe to use Autotools and add it back.
recipes/portaudio/all/conanfile.py
Outdated
|
|
||
| def configure(self): | ||
| del self.settings.compiler.libcxx | ||
| del self.settings.compiler.cppstd |
There was a problem hiding this comment.
I think that I'm missing context here. Is it now C++?
| cmake.configure() | ||
| cmake.build() | ||
| cmake = self._configure_cmake() | ||
| cmake.build() |
There was a problem hiding this comment.
There probably was a reason for using Autotools on Linus and macOS before. Got CMake support good enough for all platforms now?
|
|
||
|
|
||
| cmake = self._configure_cmake() | ||
| cmake.install() |
There was a problem hiding this comment.
Similar question, just to make sure: CMake is now installing all relevant files on all platforms?
|
I tested the recipe in Windows 7, Ubuntu 20.04, and macOS Big Sur, it seems CMake is working well but lacks the support for cpp_bindings. Would it be better to change the recipe back and use Autotools? |
|
I don't know, but I assume there was a reason for doing it like that in the first place. What was your motivation to change it to CMake-only? |
|
In PortAudio/portaudio#434, they seemed to reach a consensus that they would consider removing support for other build systems, so I think making this recipe CMake-only is helpful for compatibility with later versions |
Description
Add portaudio v19.7.0
This version fixed bug PortAudio/portaudio#395, this bug makes macOS Big Sur unable to open audio device
Related Issue
Motivation and Context
How Has This Been Tested?