Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Redeem][Application][Infra][Domain] Add ListUserRedeem #26

Closed
binchoo opened this issue Sep 19, 2022 · 2 comments
Closed

[Redeem][Application][Infra][Domain] Add ListUserRedeem #26

binchoo opened this issue Sep 19, 2022 · 2 comments

Comments

@binchoo
Copy link
Owner

binchoo commented Sep 19, 2022

image

To-be:
New features - UserRedeemListView and UserRedeemListTextView will be introduced to the Redeem domain.

  • UserRedeemListView shows a list of UserRedeem items that are recently redeemed to users by PaimonGanyu. The list will show the most recent 4~5 items descendingly ordered by date.
  • UserRedeemListTextView shows all UserRedeem items for a user within plain text format.
@binchoo binchoo added this to the release 1.1.0 milestone Sep 19, 2022
@binchoo binchoo self-assigned this Sep 19, 2022
binchoo added a commit that referenced this issue Sep 19, 2022
binchoo added a commit that referenced this issue Sep 19, 2022
binchoo added a commit that referenced this issue Sep 19, 2022
binchoo added a commit that referenced this issue Sep 19, 2022
binchoo added a commit that referenced this issue Sep 19, 2022
@binchoo binchoo added the hotfix update this feature to current release label Sep 19, 2022
@binchoo
Copy link
Owner Author

binchoo commented Sep 20, 2022

The maxCount of UserRedeems fetched from one Hoyopass can be up to 20.
max(|hoyopass.uids|) = 4
max(|items I can show in listCard|) = 5

I'd like to let the |items| be 4, so 16 is the maxCount.

@binchoo
Copy link
Owner Author

binchoo commented Sep 20, 2022

As-is:
The usability of the current UserRedeemListView is definitely so bad. Users will not get enough useful information from the current structure, because it represents UserRedeems grouped by UserHoyopass. Users cannot understand which traveler has been successful with those redeem logs.

To-be:
Show the UserRedeem list grouped by Uid, this means, by each traveler character.
image

binchoo added a commit that referenced this issue Sep 20, 2022
binchoo added a commit that referenced this issue Sep 20, 2022
@binchoo binchoo closed this as completed Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant