Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra][Application] Take out infra module from application module #20

Closed
1 task done
binchoo opened this issue Jul 21, 2022 · 4 comments
Closed
1 task done

[Infra][Application] Take out infra module from application module #20

binchoo opened this issue Jul 21, 2022 · 4 comments
Assignees
@binchoo
Labels
arch mdl: application mdl: infra stk: paimonganyu stk: paimonganyu-skill
Milestone
release 1.0.4

Comments

@binchoo
Copy link
Owner

binchoo commented Jul 21, 2022 •
edited
Loading

As-is:
The :application module has the :application:infra inside of it.

To-be:
I guess the interfaces of components in the infra module have become stable.
Therefore, no need to let the two modules be adjacent to each other.

  • Define a new Gradle project :infra at the same level of :application.
@binchoo binchoo added this to the release 1.0.4 milestone Jul 21, 2022
@binchoo binchoo self-assigned this Jul 21, 2022
@binchoo
Copy link
Owner Author

binchoo commented Jul 22, 2022 •
edited
Loading

And I created two new modules from:application.

  • :paimoganyu the serveless workflows
  • :paimoganyu-skill the skill server

New modules have the same name as our CloudFormation stacks.
It feels more natural than having single application module contain two different stacks as before.

I also renamed some modules to have paimganyu- prefix.
All changes with this update are as below.

Change Impact

  • :application ➡️ :paimonganyu-app
    • : :paimonganyu-app ⊃ :paimonganyu-app:paimonganyu
    • : :paimonganyu-app ⊃ :paimonganyu-app:paimonganyu-skill
  • :infra ➡️ :paimonganyu-infra
  • :hoyoapi ➡️ :paimonganyu-hoyoapi
  • :domain ➡️ paimonganyu-domain

binchoo added a commit that referenced this issue Jul 22, 2022
@binchoo
#20 Reconstruct hexagonal architecture
a3a3d37
@binchoo binchoo mentioned this issue Jul 22, 2022
Merged
@binchoo binchoo closed this as completed Jul 22, 2022
@binchoo
Copy link
Owner Author

binchoo commented Jul 22, 2022

README MODIFICATION REQUIRED!

binchoo added a commit that referenced this issue Jul 23, 2022
@binchoo
Resolve #20 Reconstruct hexagonal architecture
c528022
@binchoo
Copy link
Owner Author

binchoo commented Jul 23, 2022

README MODIFIED.

@binchoo
Copy link
Owner Author

binchoo commented Sep 11, 2022 •
edited
Loading

image

As-is:
The LICENSES section is incorrect with links and names of the modules.

To-be:
Use correct module names and license links.

@binchoo binchoo reopened this Sep 11, 2022
@binchoo binchoo closed this as completed Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@binchoo binchoo

Labels
arch mdl: application mdl: infra stk: paimonganyu stk: paimonganyu-skill
Projects
None yet
Milestone
release 1.0.4
Development

No branches or pull requests
1 participant
@binchoo