Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different keyboard command for switching between console types #9

Closed
danielcompton opened this issue Apr 25, 2016 · 6 comments
Closed

Different keyboard command for switching between console types #9

danielcompton opened this issue Apr 25, 2016 · 6 comments

Comments

@danielcompton
Copy link
Collaborator

On my keyboard, I don't have the Page Up and Page Down key bound to their respective keys. It would be handy to be able to provide either a button, or another key command to toggle between the two consoles.
@darwin
Copy link
Member

darwin commented Apr 27, 2016

Using a macbook? You can do PageUp using Fn + Up Arrow[1].

I have just tested it here with my macbook and it works with Dirac REPL Prompt.

I want to keep two keyboard shortcuts for next/prev prompt, because I expect possible support for more REPL prompts in the future (e.g. one for js, one for cljs, and maybe additional for clojure REPLs or some other nREPL connections).

[1] http://osxdaily.com/2015/07/07/page-up-page-down-mac-keyboard/

@danielcompton
Copy link
Collaborator Author

I'm on an external keyboard without PageUp/Down mapped. Being able to provide a custom command like Ctrl+Up/Ctrl+Down or similar would be ideal for my use case.

@darwin
Copy link
Member

darwin commented Apr 27, 2016 •
edited
Loading

The problem is that I'm using DevTools' own "_registerShortcuts" infrastructure here[1]. They don't seem to offer user-configurable keyboard shortcuts, they hard-code their own shortcuts there as well (maybe sometimes they just test for current OS). I would have to build some UI for that or build that UI in Dirac Extension and propagate that config into DevTools. That sounds like a dull job and something prone to breaking the minute I forget that something like this exists.

I would recommend you to find a way how to map page up and page down on your external keyboard. There must be some way - page up/down are quite useful keys :-)

[1]

dirac/resources/unpacked/devtools/front_end/console/ConsoleView.js

Lines 1026 to 1027 in b433537

shortcut.makeDescriptor(shortcut.Keys.PageDown),
shortcut.makeDescriptor(shortcut.Keys.PageUp)

@danielcompton
Copy link
Collaborator Author

Sure thing, I'll figure something out :)

@stumitchell
Copy link

Hi im hit by this to on the chromebook pixel. Perhaps you can follow devtools lead and offer two options (like F12 and ctrl-shift i)
maybe
PageUp = control+>
PageDown = control+<

@stumitchell stumitchell mentioned this issue May 25, 2016
Closed
@darwin darwin reopened this May 25, 2016
@darwin
Copy link
Member

darwin commented May 25, 2016

Ok, I will reconsider this for next release.

@darwin darwin closed this as completed in 457100c Jun 1, 2016
babot pushed a commit that referenced this issue Jan 24, 2017
@horo-t
Revert of Show service worker navigation preload requests in DevTools…
52a7c4d 
… Network tab (patchset #9 id:460001 of https://codereview.chromium.org/2620463002/ )

Reason for revert:
Caused layout test failures.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=http%2Ftests%2Finspector%2Fservice-workers%2Flazy-addeventlisteners.html

Original issue's description:
> Show service worker navigation preload requests in DevTools Network tab.
>
> Demo: https://youtu.be/I-Qe_Y-xYxE
>
> Navigation Preload requests are initiated from the browser process.
> This is different from the normal network requests which are initiated from the
> renderer process.
>
> When the DevTools show the normal requests in the Network tab, DevTool's
> Network events (requestWillBeSent, responseReceived, loadingFinished etc) are
> dispatched via InspectorInstrumentation and InspectorNetworkAgent.
>
> This CL introduces new DevTool's Network events (navigationPreloadSent,
> navigationPreloadResponseReceived, navigationPreloadFailed,
> navigationPreloadFinished) which are dispatched via InspectorInstrumentation and
> InspectorNetworkAgent from ServiceWorkerContextClient.
>
> In the normal requests case, we record the request sending timestamp when the
> renderer process will send the request in InspectorNetworkAgent::
> willSendRequestInternal(). But in the navigation preload case, we record the
> timestamp in the browser process, and send it to the service worker's renderer
> process using FetchEventPreloadHandle.
>
>
> BUG=649558
>
> Review-Url: https://codereview.chromium.org/2620463002
> Cr-Commit-Position: refs/heads/master@{#445630}
> Committed: https://chromium.googlesource.com/chromium/src/+/4c6b3b0f11b62e069d9d84ba99dbe94a45a5c622

[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=649558

Review-Url: https://codereview.chromium.org/2649923007
Cr-Commit-Position: refs/heads/master@{#445684}
darwin added a commit that referenced this issue Jan 25, 2017
@darwin
squash 'resources/unpacked/devtools' changes from f633692..4edefc6
53de4c8 
4edefc6 [devtools] Support different encodings for Page.CaptureScreenshot.
114d774 Show service worker navigation preload requests in DevTools Network tab.
52a7c4d Revert of Show service worker navigation preload requests in DevTools Network tab (patchset #9 id:460001 of https://codereview.chromium.org/2620463002/ )
f0d5392 DevTools: do not re-create icons for CommandResult messages
e699bfe Eliminate most usages of TimelineModel.Record in tests
a619f1f DevTools: restore shortcuts to switch devtool panel left/right
ee5c508 DevTools: format python scripts using yapf
70130f5 Show service worker navigation preload requests in DevTools Network tab.
5b9db75 DevTools: Remove unrestricted from CSSStyleDeclaration
248d833 [DevTools] Improve context and target naming.
da5db8e [DevTools] Accessibility pane: Sync highlight between a11y pane and DOM pane
55e8abd DevTools: Fix .cls field on long names
d760a09 DevTools: Do not inherit TimelineDetailsView form UI.TabbedPane
f60fc3f DevTools: enable backwards-compatibility testing
44ff055 DevTools: Fix getCookies to report for all resources
c67482d DevTools: Correct Source Panel Show/Hide Toolbar buttons
619d394 DevTools: [Persistence] start searching in JSON/MarkDown files

git-subtree-dir: resources/unpacked/devtools
git-subtree-split: 4edefc6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@darwin @stumitchell @danielcompton