Stack trace formatting removes name of function when calling multi arity functions

[danielcompton]

Dirac 0.6.0

it looks like Dirac is stripping the name of the function if a multi arity function is called?

3 @ core.cljs:4621 corresponds to

(defn into
  "Returns a new coll consisting of to-coll with all of the items of
  from-coll conjoined. A transducer may be supplied."
  ([to from]
     (if-not (nil? to)
       (if (implements? IEditableCollection to)
         (with-meta (persistent! (reduce -conj! (transient to) from)) (meta to))
         (reduce -conj to from))
       (reduce conj () from)))
  ([to xform from]
     (if (implements? IEditableCollection to)
>>>>   (with-meta (persistent! (transduce xform conj! (transient to) from)) (meta to))
       (transduce xform conj to from))))

[darwin]

I see. The problem is extra dollar in the name of those functions. It breaks on this line:

dirac/src/implant/dirac/implant/munging.cljs

Line 11 in a6a5a80

(let [index (.lastIndexOf munged-name "$")]

That function has to be smarter. Unfortunately namespace separators are just dollars and there is no simple way how to distinguish them from dollars used in function names by user.

[danielcompton]

Just one note, the dollar is part of CLJS compiler output for multi arity functions, it's not part of the function name from the user.

The generated JS for into:

/**
 * Returns a new coll consisting of to-coll with all of the items of
 *   from-coll conjoined. A transducer may be supplied.
 */
cljs.core.into = (function cljs$core$into(var_args){
var args9564 = [];
var len__6858__auto___9569 = arguments.length;
var i__6859__auto___9570 = (0);
while(true){
if((i__6859__auto___9570 < len__6858__auto___9569)){
args9564.push((arguments[i__6859__auto___9570]));

var G__9571 = (i__6859__auto___9570 + (1));
i__6859__auto___9570 = G__9571;
continue;
} else {
}
break;
}

var G__9566 = args9564.length;
switch (G__9566) {
case 2:
return cljs.core.into.cljs$core$IFn$_invoke$arity$2((arguments[(0)]),(arguments[(1)]));

break;
case 3:
return cljs.core.into.cljs$core$IFn$_invoke$arity$3((arguments[(0)]),(arguments[(1)]),(arguments[(2)]));

break;
default:
throw (new Error([cljs.core.str("Invalid arity: "),cljs.core.str(args9564.length)].join('')));

}
});

[darwin]

Still the same issue. I take last $ in the name and treat part after it as short name without namespace.

A quick workaround: Disable "Beautify function names" in Dirac Extension options on chrome://extensions page.

[danielcompton]

Great, can do!