devtools: use stable sort when sorting completion suggestions

binaryage · Jun 5, 2016 · e2c04b3 · e2c04b3
1 parent d520f0b
commit e2c04b3
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/resources/unpacked/devtools/front_end/console/DiracPrompt.js b/resources/unpacked/devtools/front_end/console/DiracPrompt.js
@@ -542,14 +542,13 @@ WebInspector.DiracPromptWithHistory.prototype = {
             return;
         }
 
-        const annotatedCompletions = completions;
-        annotatedCompletions.sort((a, b) => {
+        const sortedAnnotatedCompletions = dirac.stableSort(completions, (a, b) => {
             return a.title.localeCompare(b.title);
         });
 
-        this._markAliasedCompletions(annotatedCompletions);
+        this._markAliasedCompletions(sortedAnnotatedCompletions);
 
-        if (!annotatedCompletions.length) {
+        if (!sortedAnnotatedCompletions.length) {
             this.hideSuggestBox();
             return;
         }
@@ -562,9 +561,9 @@ WebInspector.DiracPromptWithHistory.prototype = {
             this._updateAnchorBox();
             const shouldShowForSingleItem = true; // later maybe implement inline completions like in TextPrompt.js
             if (dirac._DEBUG_COMPLETIONS) {
-                console.log("calling SuggestBox.updateSuggestions", this._anchorBox, annotatedCompletions, selectedIndex, shouldShowForSingleItem, this._userEnteredText);
+                console.log("calling SuggestBox.updateSuggestions", this._anchorBox, sortedAnnotatedCompletions, selectedIndex, shouldShowForSingleItem, this._userEnteredText);
             }
-            this._suggestBox.updateSuggestions(this._anchorBox, annotatedCompletions, selectedIndex, shouldShowForSingleItem, this._userEnteredText);
+            this._suggestBox.updateSuggestions(this._anchorBox, sortedAnnotatedCompletions, selectedIndex, shouldShowForSingleItem, this._userEnteredText);
         }
 
         // here could be implemented inline completions like in TextPrompt.js