Skip to content

Commit

Permalink
Add certificate error handling to devtools.
Browse files Browse the repository at this point in the history
This is necessary as headless chrome cannot show a UI warning for SSL
certificate errors. Instead, we can expose the errors as DevTools events
and control the action to take through a DevTools command.

BUG=659662

Review-Url: https://codereview.chromium.org/2639203003
Cr-Commit-Position: refs/heads/master@{#458673}
  • Loading branch information
irisu authored and Commit bot committed Mar 22, 2017
1 parent 8713e2d commit 9db9a2b
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions front_end/security/SecurityModel.js
Original file line number Diff line number Diff line change
Expand Up @@ -108,4 +108,14 @@ Security.SecurityDispatcher = class {
securityState, schemeIsCryptographic, explanations, insecureContentStatus, summary || null);
this._model.dispatchEventToListeners(Security.SecurityModel.Events.SecurityStateChanged, pageSecurityState);
}


/**
* @override
* @param {number} eventId
* @param {string} errorType
* @param {string} requestURL
*/
certificateError(eventId, errorType, requestURL) {
}
};

0 comments on commit 9db9a2b

Please sign in to comment.