Skip to content

Commit

Permalink
[DevTools] Generate public versions of protocol classes to be exposed…
Browse files Browse the repository at this point in the history
… in v8_inspector/public.

This includes RemoteObject, StackTrace and SearchMatch. Each API class has toJSONString() and fromJSONString() methods.
On embedder side, we also generate ValueConversions for public types, which allow opaque interoperability
between classes of two dependent protocols.

Added SerializedValue to store opaque string as is.

This patch allows to remove protocol::Value from public API of v8_inspector.

BUG=580337

Review-Url: https://codereview.chromium.org/2159633002
Cr-Commit-Position: refs/heads/master@{#407375}
  • Loading branch information
dgozman authored and Commit bot committed Jul 23, 2016
1 parent c6c550c commit 89338eb
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions front_end/sdk/RemoteObject.js
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ WebInspector.RemoteObjectImpl.prototype = {
/**
* @param {function(?)} fulfill
* @param {function(*)} reject
* @this {WebInspector.RemoteObject}
* @this {WebInspector.RemoteObjectImpl}
*/
function eventListeners(fulfill, reject)
{
Expand All @@ -521,7 +521,7 @@ WebInspector.RemoteObjectImpl.prototype = {
this.target().domdebuggerAgent().getEventListeners(this._objectId, mycallback.bind(this));

/**
* @this {!WebInspector.RemoteObject}
* @this {WebInspector.RemoteObjectImpl}
* @param {?Protocol.Error} error
* @param {!Array<!DOMDebuggerAgent.EventListener>} payloads
*/
Expand All @@ -535,7 +535,7 @@ WebInspector.RemoteObjectImpl.prototype = {
}

/**
* @this {!WebInspector.RemoteObject}
* @this {WebInspector.RemoteObjectImpl}
* @param {!DOMDebuggerAgent.EventListener} payload
*/
function createEventListener(payload)
Expand All @@ -547,7 +547,7 @@ WebInspector.RemoteObjectImpl.prototype = {
payload.passive,
payload.handler ? this.target().runtimeModel.createRemoteObject(payload.handler) : null,
payload.originalHandler ? this.target().runtimeModel.createRemoteObject(payload.originalHandler) : null,
WebInspector.DebuggerModel.Location.fromPayload(this._debuggerModel, payload.location),
/** @type {!WebInspector.DebuggerModel.Location} */ (this._debuggerModel.createRawLocationByScriptId(payload.scriptId, payload.lineNumber, payload.columnNumber)),
payload.removeFunction ? this.target().runtimeModel.createRemoteObject(payload.removeFunction) : null);
}
}
Expand Down

0 comments on commit 89338eb

Please sign in to comment.