Skip to content

Commit

Permalink
DevTools: fix network waterfall sorting icon
Browse files Browse the repository at this point in the history
This patch:
- hides network waterfall sorting icon if other column is used for sorting
- makes icon crisp on retina

BUG=684894
R=dgozman, allada

Review-Url: https://codereview.chromium.org/2652893008
Cr-Commit-Position: refs/heads/master@{#445921}
  • Loading branch information
aslushnikov authored and Commit bot committed Jan 25, 2017
1 parent 1ac9326 commit 6a0cd76
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
4 changes: 2 additions & 2 deletions front_end/network/NetworkLogViewColumns.js
Original file line number Diff line number Diff line change
Expand Up @@ -263,9 +263,9 @@ Network.NetworkLogViewColumns = class {
var columnId = this._dataGrid.sortColumnId();
this._networkLogView.removeAllNodeHighlights();
this._waterfallRequestsAreStale = true;
if (columnId === 'waterfall') {
this._waterfallColumnSortIcon.classList.remove('sort-ascending', 'sort-descending');
this._waterfallColumnSortIcon.classList.remove('sort-ascending', 'sort-descending');

if (columnId === 'waterfall') {
if (this._dataGrid.sortOrder() === DataGrid.DataGrid.Order.Ascending)
this._waterfallColumnSortIcon.classList.add('sort-ascending');
else
Expand Down
6 changes: 6 additions & 0 deletions front_end/network/networkLogView.css
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,12 @@
display: none;
}

@media (-webkit-min-device-pixel-ratio: 1.1) {
.network-waterfall-header .sort-order-icon {
background-image: url(Images/toolbarButtonGlyphs_2x.png);
}
} /* media */

.network-waterfall-header .sort-ascending.sort-order-icon {
display: block;
background-position: -4px -111px;
Expand Down

0 comments on commit 6a0cd76

Please sign in to comment.