devtools: gray out aliased names in completion suggestions box

binaryage · May 17, 2016 · 58f0cd9 · 58f0cd9
1 parent d1fc0c7
commit 58f0cd9
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 2 deletions.
diff --git a/resources/unpacked/devtools/front_end/console/DiracPrompt.js b/resources/unpacked/devtools/front_end/console/DiracPrompt.js
@@ -455,7 +455,7 @@ WebInspector.DiracPromptWithHistory.prototype = {
               var locals = this._extractLocalsFromScopeInfo(scopeInfo);
               var filteredLocals = locals.filter(item => item.name.startsWith(input));
               var annotatedCompletions = filteredLocals.map(item => ({title: item.name || "?",
-                                                                       info: item.identifier,
+                                                                       info: item.identifier?"js/"+item.identifier:undefined,
                                                                   className: "suggest-cljs-scope"}));
               annotatedCompletions.reverse(); // we want to display inner scopes first
               return annotatedCompletions;
@@ -480,6 +480,23 @@ WebInspector.DiracPromptWithHistory.prototype = {
         }
     },
 
+    _markAliasedCompletions: function(annotatedCompletions) {
+        var previous = null;
+        for (var i=0; i<annotatedCompletions.length; i++) {
+            var current = annotatedCompletions[i];
+
+            if (previous) {
+                if (current.title === previous.title) {
+                    if (!current.className) {
+                        current.className = "";
+                    }
+                    current.className += " suggest-aliased";
+                }
+            }
+            previous = current;
+        }
+    },
+
     /**
      * @param {string} prefix
      * @param {boolean} reverse
@@ -497,6 +514,8 @@ WebInspector.DiracPromptWithHistory.prototype = {
         var annotatedCompletions = completions;
         annotatedCompletions.sort(function(a, b) { return a.title.localeCompare(b.title); });
 
+        this._markAliasedCompletions(annotatedCompletions);
+
         if (!this._waitingForCompletions || !annotatedCompletions.length) {
             this.hideSuggestBox();
             return;

diff --git a/resources/unpacked/devtools/front_end/ui/suggestBox.css b/resources/unpacked/devtools/front_end/ui/suggestBox.css
@@ -208,10 +208,18 @@
     text-align: right;
 }
 
+.suggest-box .suggest-box-content-item.suggest-aliased .prefix {
+   color: #ccc;
+}
+
+.suggest-box .suggest-box-content-item.suggest-aliased .suffix{
+   color: #ccc;
+}
+
 .suggest-box .suggest-box-content-item .info {
     font-size: 8px;
     float: right;
-    color: #ccc;
+    color: #aaf;
     padding: 0px 6px;
     position: relative;
     top: 2px;