DevTools: remove ElementsTreeElement.updateSelection.

BUG=627306 NOTRY=true Review-Url: https://codereview.chromium.org/2137313003 Cr-Commit-Position: refs/heads/master@{#404852}
binaryage · Jul 12, 2016 · 21cc3d9 · 21cc3d9
1 parent e02009f
commit 21cc3d9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 37 deletions.
diff --git a/front_end/elements/ElementsPanel.js b/front_end/elements/ElementsPanel.js
@@ -299,7 +299,6 @@ WebInspector.ElementsPanel.prototype = {
             width -= this._splitWidget.sidebarSize();
         for (var i = 0; i < this._treeOutlines.length; ++i) {
             this._treeOutlines[i].setVisibleWidth(width);
-            this._treeOutlines[i].updateSelection();
         }
         this._breadcrumbs.updateSizes();
     },
@@ -337,7 +336,6 @@ WebInspector.ElementsPanel.prototype = {
 
         for (var i = 0; i < this._treeOutlines.length; ++i) {
             var treeOutline = this._treeOutlines[i];
-            treeOutline.updateSelection();
             treeOutline.setVisible(true);
 
             if (!treeOutline.rootDOMNode)
@@ -559,14 +557,6 @@ WebInspector.ElementsPanel.prototype = {
         this._contentElement.classList.toggle("elements-wrap", event.data);
         for (var i = 0; i < this._treeOutlines.length; ++i)
             this._treeOutlines[i].setWordWrap(/** @type {boolean} */ (event.data));
-
-        var selectedNode = this.selectedDOMNode();
-        if (!selectedNode)
-            return;
-
-        var treeElement = this._treeElementForNode(selectedNode);
-        if (treeElement)
-            treeElement.updateSelection(); // Recalculate selection highlight dimensions.
     },
 
     switchToAndFocus: function(node)

diff --git a/front_end/elements/ElementsTreeElement.js b/front_end/elements/ElementsTreeElement.js
@@ -229,7 +229,7 @@ WebInspector.ElementsTreeElement.prototype = {
 
         if (this.listItemElement) {
             if (x) {
-                this.updateSelection();
+                this._createSelection();
                 this.listItemElement.classList.add("hovered");
             } else {
                 this.listItemElement.classList.remove("hovered");
@@ -253,7 +253,7 @@ WebInspector.ElementsTreeElement.prototype = {
         this._expandedChildrenLimit = expandedChildrenLimit;
     },
 
-    updateSelection: function()
+    _createSelection: function()
     {
         var listItemElement = this.listItemElement;
         if (!listItemElement)
@@ -290,7 +290,7 @@ WebInspector.ElementsTreeElement.prototype = {
     onattach: function()
     {
         if (this._hovered) {
-            this.updateSelection();
+            this._createSelection();
             this.listItemElement.classList.add("hovered");
         }
 
@@ -337,7 +337,6 @@ WebInspector.ElementsTreeElement.prototype = {
             return;
 
         this.updateTitle();
-        this.treeOutline.updateSelection();
     },
 
     oncollapse: function()
@@ -346,7 +345,6 @@ WebInspector.ElementsTreeElement.prototype = {
             return;
 
         this.updateTitle();
-        this.treeOutline.updateSelection();
     },
 
     /**
@@ -373,7 +371,7 @@ WebInspector.ElementsTreeElement.prototype = {
         this.treeOutline.selectDOMNode(this._node, selectedByUser);
         if (selectedByUser)
             this._node.highlight();
-        this.updateSelection();
+        this._createSelection();
         this.treeOutline.suppressRevealAndSelect = false;
         return true;
     },
@@ -454,8 +452,6 @@ WebInspector.ElementsTreeElement.prototype = {
             tag.appendChild(node);
             tag.createTextChild(">");
         }
-
-        this.updateSelection();
     },
 
     /**
@@ -810,8 +806,6 @@ WebInspector.ElementsTreeElement.prototype = {
         this.listItemElement.classList.add("editing-as-html");
         this.treeOutline.element.addEventListener("mousedown", consume, false);
 
-        this.updateSelection();
-
         /**
          * @param {!Element} element
          * @param {string} newValue
@@ -847,7 +841,6 @@ WebInspector.ElementsTreeElement.prototype = {
             }
 
             this.treeOutline.element.removeEventListener("mousedown", consume, false);
-            this.updateSelection();
             this.treeOutline.focus();
         }
 
@@ -1079,7 +1072,7 @@ WebInspector.ElementsTreeElement.prototype = {
 
         delete this.selectionElement;
         if (this.selected)
-            this.updateSelection();
+            this._createSelection();
         this._preventFollowingLinksOnDoubleClick();
         this._highlightSearchResults();
     },

diff --git a/front_end/elements/ElementsTreeOutline.js b/front_end/elements/ElementsTreeOutline.js
@@ -439,14 +439,6 @@ WebInspector.ElementsTreeOutline.prototype = {
             this._revealAndSelectNode(selectedNode, true);
     },
 
-    updateSelection: function()
-    {
-        if (!this.selectedTreeElement)
-            return;
-        var element = this.selectedTreeElement;
-        element.updateSelection();
-    },
-
     _selectedNodeChanged: function()
     {
         this.dispatchEventToListeners(WebInspector.ElementsTreeOutline.Events.SelectedNodeChanged, this._selectedDOMNode);
@@ -743,7 +735,6 @@ WebInspector.ElementsTreeOutline.prototype = {
             node = node.parentNode;
         }
 
-        treeElement.updateSelection();
         treeElement.listItemElement.classList.add("elements-drag-over");
         this._dragOverTreeElement = treeElement;
         event.preventDefault();
@@ -822,7 +813,6 @@ WebInspector.ElementsTreeOutline.prototype = {
     _clearDragOverTreeElementMarker: function()
     {
         if (this._dragOverTreeElement) {
-            this._dragOverTreeElement.updateSelection();
             this._dragOverTreeElement.listItemElement.classList.remove("elements-drag-over");
             delete this._dragOverTreeElement;
         }
@@ -1243,7 +1233,6 @@ WebInspector.ElementsTreeOutline.prototype = {
             this._element.classList.remove("hidden");
             if (originalScrollTop)
                 treeOutlineContainerElement.scrollTop = originalScrollTop;
-            this.updateSelection();
         }
 
         this._updateRecords.clear();
@@ -1750,10 +1739,6 @@ WebInspector.ElementsTreeOutline.ShortcutTreeElement.prototype = {
         this.listItemElement.classList.toggle("hovered", x);
     },
 
-    updateSelection: function()
-    {
-    },
-
     /**
      * @return {number}
      */