Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated login url #85

Merged
merged 4 commits into from
Sep 19, 2018
Merged

updated login url #85

merged 4 commits into from
Sep 19, 2018

Conversation

m1n3rva
Copy link
Contributor

@m1n3rva m1n3rva commented Sep 19, 2018

This hopefully fixes #84

It seems the login url to the BMW server has changed:
old url: webapi/oauth/token
new_url: gcdm/oauth/token

This seems to have fixed it for me. Please test this also in North America 🌎 and China 🌏 , they might also have different urls...

@m1n3rva m1n3rva merged commit db3b76d into master Sep 19, 2018
@m1n3rva m1n3rva deleted the url_change branch September 19, 2018 08:13
@wywywywy
Copy link

Thank you. I'll give it a test as soon as possible.

Is pip going to be updated as well?

@m1n3rva
Copy link
Contributor Author

m1n3rva commented Sep 19, 2018

yep release is just out: v0.5.2

@MJP-76
Copy link

MJP-76 commented Sep 19, 2018

Many Thanks. Will this get pushed into the HASSIO component

@wywywywy
Copy link

Just gave it a test and everything seems good so far!

@wywywywy
Copy link

wywywywy commented Sep 19, 2018

As of 2 hours ago, it appears to be broke again unfortunately.

Unknown status code 404, expected 200
{"error":"not_found","error_description":"The requested resource does not exists"}

EDIT - It's back on. Probably just an unrelated temporary server problem.

@gerard33
Copy link
Member

gerard33 commented Sep 19, 2018

Fixed it for me as well. Will check if I also get the error above, if not I can make a PR for Home Assistant to update to v0.5.2.

Issue was apparently not there for US, see this post on the forum.

@gerard33
Copy link
Member

I see some 401 codes in the log but besides that the component is running fine.
Will make a PR to bump the version in Home Assistant.

@gerard33
Copy link
Member

PR for HA is home-assistant/core#16780.

m1n3rva added a commit that referenced this pull request Sep 25, 2018
* updated login url

* fixed url in tests

* fixed pylint warnings

* incremented version number to 0.5.2
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stopped working since 17th Sept. BMW server change?
4 participants