IdentityClientOptions clone method mistakenly enables probing for bro…

…ker support (Azure#39002)
billwert · Mar 1, 2024 · 5688333 · 5688333
1 parent a55b723
commit 5688333
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/...azure-identity/src/main/java/com/azure/identity/implementation/IdentityClientOptions.java b/...azure-identity/src/main/java/com/azure/identity/implementation/IdentityClientOptions.java
@@ -818,9 +818,12 @@ public IdentityClientOptions clone() {
             .setPerCallPolicies(this.perCallPolicies)
             .setPerRetryPolicies(this.perRetryPolicies)
             .setBrowserCustomizationOptions(this.browserCustomizationOptions)
-            .setChained(this.isChained)
-            .setBrokerWindowHandle(this.brokerWindowHandle)
-            .setEnableLegacyMsaPassthrough(this.enableMsaPassthrough);
+            .setChained(this.isChained);
+
+        if (isBrokerEnabled()) {
+            clone.setBrokerWindowHandle(this.brokerWindowHandle);
+            clone.setEnableLegacyMsaPassthrough(this.enableMsaPassthrough);
+        }
         if (!isInstanceDiscoveryEnabled()) {
             clone.disableInstanceDiscovery();
         }

diff --git a/...e-identity/src/test/java/com/azure/identity/implementation/IdentityClientOptionsTest.java b/...e-identity/src/test/java/com/azure/identity/implementation/IdentityClientOptionsTest.java
@@ -42,4 +42,13 @@ public void testDisableAuthorityValidationAndInstanceDiscovery() {
         identityClientOptions.disableInstanceDiscovery();
         Assertions.assertFalse(identityClientOptions.isInstanceDiscoveryEnabled());
     }
+
+    @Test
+    public void testCloneDoesNotEnableThingsItShouldNot() {
+        IdentityClientOptions identityClientOptions = new IdentityClientOptions();
+
+        IdentityClientOptions clonedOptions = identityClientOptions.clone();
+        Assertions.assertFalse(clonedOptions.isBrokerEnabled());
+        Assertions.assertFalse(clonedOptions.isUnsafeSupportLoggingEnabled());
+    }
 }