Skip to content

Commit

Permalink
Turn off methane in dynlakes test
Browse files Browse the repository at this point in the history
I was getting a gridcell-level methane balance check error when running
ERS_Lm25.1x1_smallvilleIA.IHistClm50BgcCropQianRsGs.cheyenne_gnu.clm-smallville_dynlakes_monthly.
I'm thinking it was due to ESCOMP#43. So for now, I'm disabling
methane in this testmod. (I thought about changing it to an Sp case, but
(1) currently you're not allowed to run smallville in an Sp case, and
(2) it would be nice to exercise as much of the BGC code as possible in
this test, to exercise the dynamic landunit conservation code for BGC
variables.)
  • Loading branch information
billsacks committed Sep 25, 2020
1 parent 3ab74de commit 8ff6ca3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,7 @@ do_transient_lakes = .true.
! Note that the use of this file means that this testmod can only be
! used with the 1x1_smallvilleIA grid.
flanduse_timeseries = '$DIN_LOC_ROOT/lnd/clm2/surfdata_map/landuse.timeseries_1x1_smallvilleIA_hist_78pfts_simyr1850-1855_dynLakes_c200923.nc'

! BUG(wjs, 2020-09-25, ESCOMP/CTSM#43) Dynamic lakes don't work when methane is active,
! so for now disable methane for this test.
use_lch4 = .false.
2 changes: 1 addition & 1 deletion src/biogeochem/ch4Mod.F90
Original file line number Diff line number Diff line change
Expand Up @@ -1251,7 +1251,7 @@ subroutine DynamicColumnAdjustments(this, bounds, clump_index, column_state_upda
character(len=*), parameter :: subname = 'DynamicColumnAdjustments'
!-----------------------------------------------------------------------

! BUG(wjs, 2016-02-16, bugz 2283) Need to do some special handling of finundated for
! BUG(wjs, 2016-02-16, ESCOMP/CTSM#43) Need to do some special handling of finundated for
! increases in lake area, since lakes are assumed to be 100% inundated. Probably it's
! most appropriate for this special handling to happen elsewhere - i.e., within this
! routine, we do the standard adjustments as they are currently done, but then in the
Expand Down

0 comments on commit 8ff6ca3

Please sign in to comment.