Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 9.x Compatibility #16

Merged
merged 9 commits into from
Feb 10, 2022
Merged

Conversation

laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

  • Checkout the l9-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚠️ Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 9. However, you should review these changes to ensure the desired combination of versions are built for your package.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-http-client-logger.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "bilfeldt/laravel-http-client-logger": "dev-l9-compatibility",
    }
}

Finally, run: composer update

@bilfeldt
Copy link
Owner

bilfeldt commented Feb 6, 2022

Currently awaiting approval of timacdonald/log-fake#32

@bilfeldt bilfeldt merged commit 9e58a20 into bilfeldt:master Feb 10, 2022
@lionslair
Copy link

Did you just run a normal laravel shift 8-9 to produce this? Didn't know shift works on packages.

@bilfeldt
Copy link
Owner

Did you just run a normal laravel shift 8-9 to produce this? Didn't know shift works on packages.

No actually Shift made it automatically without my request: https://twitter.com/laravelshift/status/1490709249491714050?s=21

I assume they made them for packages used in projects that have used a paid shift.

@jasonmccreary
Copy link

@lionslair, @bilfeldt, they are collected from our Can I Upgrade Laravel tool.

It is offered to help community packages prepare for new releases of Laravel.

@lionslair
Copy link

That Did a pr though. Hmm interesting. If you have code incompatibility will it fix that or just the composer file

@jasonmccreary
Copy link

@lionslair, its focus is mostly on compatibility. Future runs may try to analyze the code too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants