ENH: add Planck15_LAL cosmology #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj-will
commented
Oct 31, 2024
mj-will
force-pushed
the
planck15-lal-cosmo
branch
from
4b611f2 to
97fa8ce
Compare
|
I can confirm that these are the conventional numbers dating back to https://arxiv.org/abs/1602.03840 |
|
Code-wise this looks good to me! Should we consider adding a test comparing luminosity distances calculated by |
ColmTalbot
requested changes
Nov 5, 2024
mj-will
force-pushed
the
planck15-lal-cosmo
branch
from
c5a450f to
759f48f
Compare
I've added a test for this, for now it uses a manual version of the LAL cosmology but once changes from https://git.ligo.org/lscsoft/lalsuite/-/merge_requests/2368 at in a release, we can switch to that. |
ColmTalbot
approved these changes
Nov 6, 2024
JasperMartins
pushed a commit
to JasperMartins/bilby
that referenced
this pull request
Nov 12, 2024
* ENH: add Planck15_LAL cosmology * MAINT: add Planck15_LAL to known cosmologies * DOC: update doc-string Co-authored-by: Colm Talbot <[email protected]> * TST: add test for Planck15 LAL cosmology --------- Co-authored-by: Colm Talbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Planck15_LAL cosmology as defined in: https://dcc.ligo.org/DocDB/0167/T2000185/005/LVC_symbol_convention.pdf
Note: there are additional commits in this PR since it requires the PR listed below. It should be rebased before being reviewed.
Requires: #828