Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: add sampler deprecation warning #822

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

mj-will
Copy link
Collaborator

@mj-will mj-will commented Oct 7, 2024

In preparation for removing the nessai and pypolychord interfaces, I've added warnings whenever they are used.

Related to #795 and #774

Original GitLab MR: https://git.ligo.org/lscsoft/bilby/-/merge_requests/1381

@mj-will mj-will added sampling Issues about sampling algorithms, their efficiency and robustness gitlab merge request labels Oct 7, 2024
@mj-will mj-will added this to the 2.4.0 milestone Oct 7, 2024
@mj-will mj-will requested review from asb5468 and ColmTalbot October 7, 2024 15:29
@mj-will mj-will force-pushed the add-sampler-deprecation-warning branch from 155d2d4 to 7d79ce3 Compare October 8, 2024 07:27
@mj-will mj-will merged commit f6de673 into bilby-dev:main Oct 8, 2024
10 checks passed
@mj-will mj-will deleted the add-sampler-deprecation-warning branch October 8, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gitlab merge request sampling Issues about sampling algorithms, their efficiency and robustness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transitioning to sampler plugins Time to remove polychord?
3 participants