BUGFIX: Joint prior subclassing fixes #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColmTalbot
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Thanks @JasperMartins I'm happy with these changes and it looks like they are well covered in tests.
On the point about being able to instantiate the base distribution. We generally haven't been good about making base classes unusable, it would be nice longer term to track down the various places we should either have some kind of abstract base or a bunch of NotImplementedErrors.
ColmTalbot
changed the title
…ing saved Joint priors
ColmTalbot
force-pushed
the
joint_prior_subclassing_fixes
branch
from
d3da588 to
883662d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses multiple issues with the subclassing of BaseJointPrior lists and their reinitialization from
jsonordictoutlined in #31, implements fixes and also test cases that fail with the old implementation.The tests uncovered some new issues that required fixes beyond the (current) discussion in #31. The fixes are implemented by moving some of the logic used to re-initialize (subclasses of)
BaseJointPriorDistfromMultivariateGaussianDisttoBaseJointPriorDist.The tests also uncovered a problem with
__eq__forJointPriorthat resulted in__eq__givingFalseif thedistkeyword does not point to the same instance. This, I felt, was inconsistent with the usage of__eq__acrossPriorDict.One overall change currently applied by this PR is that it is now easier to, by mistake, use a not-subclassed
BaseJointPriorDistsomewhere. I wonder, however, if theBaseJointPriorDistmethods that need be subclassed should not raise anNotImplementederror anyway.