Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArangoDB Support #94

Open
ManevilleF opened this issue Mar 22, 2021 · 5 comments · May be fixed by #153
Open

ArangoDB Support #94

ManevilleF opened this issue Mar 22, 2021 · 5 comments · May be fixed by #153
Labels
A-aragog Area: aragog / deadpool-aragog help wanted Extra attention is needed

Comments

@ManevilleF
Copy link

Hello,

I'm the creator of the aragog crate, an ODM/OGM for ArangoDB and I want to implement the deadpool pattern for my lib.

What is the preferred way?

  • Add the implementation on this repository
  • Add the implementation on a custom crate which can be referenced on your README
  • Add an optional implementation directly on my crate with a feature gate
@bikeshedder
Copy link
Owner

Having the implementation inside the repository would be nice as it would allow me to make releases for all implementation crates in one go whenever changing something from the deadpool crate (0.8 is incoming).

But then I wonder if I should rather extract the Manager trait into a separate crate which can be 100% stable and reduce the version dependencies even more. See #90

@ManevilleF
Copy link
Author

I don't know if it's a good idea to have everything inside of the deadpool repository, why don't you do something more similar to r2d2 ?

@bikeshedder bikeshedder added A-aragog Area: aragog / deadpool-aragog help wanted Extra attention is needed labels Aug 18, 2021
@Weasy666
Copy link

Weasy666 commented Oct 6, 2021

I have implemented deadpool for a ArangoDB backend, deadpool-arangodb, and wanted to ask how i should proceed with publishing? I don't want to just use the deadpool- "namespace" without asking. So...can i publish it as deadpool-arangodb or should i use a different name? I am also open to moving the code inside the deadpool repository.

@bikeshedder
Copy link
Owner

Thank you for asking. Others have just used that "namespace" and created "inofficial" pool implementations based on deadpool.

Deadpool 0.9 is about to be released (0.9 Milestone). The only blocking issues are #149 and #152. I have mostly working code for both of them and I plan to make that release by the end of this week.

After that 1.0 is all about final API stabilization and making it even more production ready by adding support for tokio-tracing, etc.

At the current state of deadpool I'd prefer the code being part of the deadpool codebase so it becomes part of the CI tests. If you want to contribute that code I'd be more than happy to accept a PR. This is not a must and if you prefer to keep control over the code I can understand that.

@Weasy666
Copy link

Weasy666 commented Oct 6, 2021

Great. Then i'll create a PR today or tomorrow, to move my code into the deadpool codebase.

@Weasy666 Weasy666 linked a pull request Oct 8, 2021 that will close this issue
@bikeshedder bikeshedder linked a pull request Nov 26, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-aragog Area: aragog / deadpool-aragog help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants