Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discarded objects due to pool resize don't get reported via Manager::detach #152

Closed
bikeshedder opened this issue Sep 30, 2021 · 0 comments · Fixed by #157
Closed

Discarded objects due to pool resize don't get reported via Manager::detach #152

bikeshedder opened this issue Sep 30, 2021 · 0 comments · Fixed by #157
Assignees
@bikeshedder
Labels
A-core Area: Core / deadpool bug Category: This is a bug.
Milestone
0.9.0

Comments

@bikeshedder
Copy link
Owner

It is important that Manager::detach is called for every object that leaves the control of the pool. Otherwise the StatementCaches of tokio-postgres can't remove the StatementCache from its internal Vec leading to a memory leak.
@bikeshedder bikeshedder added bug Category: This is a bug. A-core Area: Core / deadpool labels Sep 30, 2021
@bikeshedder bikeshedder added this to the 0.9 milestone Sep 30, 2021
@bikeshedder bikeshedder self-assigned this Sep 30, 2021
@bikeshedder bikeshedder mentioned this issue Oct 6, 2021
Open
bikeshedder added a commit that referenced this issue Oct 17, 2021
@bikeshedder
Always detach objects from manager
a2f3c8e 
This fixes #152
@bikeshedder bikeshedder mentioned this issue Oct 17, 2021
Merged
bikeshedder added a commit that referenced this issue Oct 17, 2021
@bikeshedder
Always detach objects from manager
45a8a9f 
This fixes #152
bikeshedder added a commit that referenced this issue Oct 17, 2021
@bikeshedder
Always detach objects from manager
1248e01 
This fixes #152
bikeshedder added a commit that referenced this issue Oct 18, 2021
@bikeshedder
Fix detaching of objects
eac72c4 
This is related to #152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bikeshedder bikeshedder

Labels
A-core Area: Core / deadpool bug Category: This is a bug.
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

Always detach objects from manager bikeshedder/deadpool
1 participant
@bikeshedder