forked from angular-schule/ngx-deploy-starter
-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: drop support for Angular workspaces #560
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have decided to stop supporting Angular Workspaces and focus exclusively on Nx Workspaces. This decision is motivated by several factors, including the fact that the Nx Devkit no longer supports compatibility with Angular Workspaces. To offer support, we would have to create a second plugin that uses AngularDevkit under the hood, which would require considerable effort on the part of our maintainers. We want to focus on what brings the most value to our current users, and Nx Workspaces is the best way to do that. BREAKING CHANGE: As an alternative, maintainers suggest migrating your Angular Workspaces to Nx Workspaces if you want to use this plugin. A stand-alone approach to Nx workspaces is an option that you should consider. We apologize for any inconvenience this may cause and appreciate your understanding. close #467
dianjuar
force-pushed
the
drop-angular-support
branch
from
November 24, 2023 18:37
3fa9194
to
e80c929
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
dianjuar
added a commit
that referenced
this pull request
Jan 13, 2024
We have decided to stop supporting Angular Workspaces and focus exclusively on Nx Workspaces. This decision is motivated by several factors, including that the Nx Devkit no longer supports compatibility with Angular Workspaces. To offer support, we would have to create a second plugin that uses AngularDevkit under the hood, which would require considerable effort on the part of our maintainers. We want to focus on what brings the most value to our current users, and Nx Workspaces is the best way to do that. BREAKING CHANGE: As an alternative, maintainers suggest migrating your Angular Workspaces to Nx Workspaces if you want to use this plugin. A stand-alone approach to Nx workspaces is an option that you should consider. We apologize for any inconvenience this may cause and appreciate your understanding.
dianjuar
added a commit
that referenced
this pull request
Jan 15, 2024
We have decided to stop supporting Angular Workspaces and focus exclusively on Nx Workspaces. This decision is motivated by several factors, including that the Nx Devkit no longer supports compatibility with Angular Workspaces. To offer support, we would have to create a second plugin that uses AngularDevkit under the hood, which would require considerable effort on the part of our maintainers. We want to focus on what brings the most value to our current users, and Nx Workspaces is the best way to do that. BREAKING CHANGE: As an alternative, maintainers suggest migrating your Angular Workspaces to Nx Workspaces if you want to use this plugin. A stand-alone approach to Nx workspaces is an option that you should consider. We apologize for any inconvenience this may cause and appreciate your understanding.
dianjuar
added a commit
that referenced
this pull request
Jan 16, 2024
We have decided to stop supporting Angular Workspaces and focus exclusively on Nx Workspaces. This decision is motivated by several factors, including that the Nx Devkit no longer supports compatibility with Angular Workspaces. To offer support, we would have to create a second plugin that uses AngularDevkit under the hood, which would require considerable effort on the part of our maintainers. We want to focus on what brings the most value to our current users, and Nx Workspaces is the best way to do that. BREAKING CHANGE: As an alternative, maintainers suggest migrating your Angular Workspaces to Nx Workspaces if you want to use this plugin. A stand-alone approach to Nx workspaces is an option that you should consider. We apologize for any inconvenience this may cause and appreciate your understanding.
dianjuar
added a commit
that referenced
this pull request
Jan 18, 2024
We have decided to stop supporting Angular Workspaces and focus exclusively on Nx Workspaces. This decision is motivated by several factors, including that the Nx Devkit no longer supports compatibility with Angular Workspaces. To offer support, we would have to create a second plugin that uses AngularDevkit under the hood, which would require considerable effort on the part of our maintainers. We want to focus on what brings the most value to our current users, and Nx Workspaces is the best way to do that. BREAKING CHANGE: As an alternative, maintainers suggest migrating your Angular Workspaces to Nx Workspaces if you want to use this plugin. A stand-alone approach to Nx workspaces is an option that you should consider. We apologize for any inconvenience this may cause and appreciate your understanding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
Issue Number: #467
What is the new behavior?
This plugin will no longer work on an Angular Workspace.
Does this PR introduce a breaking change?
We have decided to stop supporting Angular Workspaces and focus exclusively on Nx Workspaces. This decision is motivated by several factors, including the fact that the Nx Devkit no longer supports compatibility with Angular Workspaces. To offer support, we would have to create a second plugin that uses AngularDevkit under the hood, which would require considerable effort on the part of our maintainers. We want to focus on what brings the most value to our current users, and Nx Workspaces is the best way to do that.
As an alternative, maintainers suggest migrating your Angular Workspaces to Nx Workspaces if you want to use this plugin. A stand-alone approach to Nx workspaces is an option that you should consider. We apologize for any inconvenience this may cause and appreciate your understanding.
Other information