Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed random pause/hesitation when printing #2827

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

digant73
Copy link
Contributor

@digant73 digant73 commented Aug 23, 2023

BUGFIXES:

fixes #2761

PR STATE: Ready for merge

@rondlh
Copy link

rondlh commented Aug 23, 2023

How to get this PR merged asap?

@digant73
Copy link
Contributor Author

digant73 commented Aug 23, 2023

It seems to be enough to solve the issue (just keeping in this PR the minimal code).Serial_Get (reader) and USART_IRQHandler (writer) are totally decoupled now. #2761 is open since April. Other features like advanced ok or any other improvement can be provided in a separate PR.

@rondlh
Copy link

rondlh commented Aug 23, 2023

It seems to be enough to solve the issue (just keeping in this PR the minimal code).Serial_Get (reader) and USART_IRQHandler (writer) are totally decoupled now. #2761 is open since April. Other features like advanced ok or any other improvement can be provided in a separate PR.

@digant73 Are you responding to me? If so then you seem to have misunderstood my question...

@digant73
Copy link
Contributor Author

digant73 commented Aug 23, 2023

It seems to be enough to solve the issue (just keeping in this PR the minimal code).Serial_Get (reader) and USART_IRQHandler (writer) are totally decoupled now. #2761 is open since April. Other features like advanced ok or any other improvement can be provided in a separate PR.

@digant73 Are you responding to me? If so then you seem to have misunderstood my question...

I have also to work and travel during the day. If you are afraid about the possible issue due to no use of volatile for wIndex I just made an edit in my last comment in #2761. It will be added.

@rondlh
Copy link

rondlh commented Aug 23, 2023

I have also to work and travel during the day. If you are afraid about the possible issue due to no use of volatile for wIndex I just made an edit in my last comment in #2761. It will be added.

I mean this... many PRs have NOT been merged for a long time, perhaps BTT is not paying much attention, so the question is how do we get your recent work merged asap? I'm not worried about the volatile variable, it has been off during all of my testing.

@digant73
Copy link
Contributor Author

digant73 commented Aug 23, 2023

I have also to work and travel during the day. If you are afraid about the possible issue due to no use of volatile for wIndex I just made an edit in my last comment in #2761. It will be added.

I mean this... many PRs have NOT been merged for a long time, perhaps BTT is not paying much attention, so the question is how do we get your recent work merged asap? I'm not worried about the volatile variable, it has been off during all of my testing.

I can only suppose that some PRs are not merged for reasons that the author perfectly know. After that said, as far as I see BTT is OoO since more than 10 days. I already asked BTT to consider to merge many PRs if it can help.
In the meanwhile users having the issue in #2761 can download this small PR and test it. It was not even planned from my side due to all the private club unfortunately terminated with no public PR release at all... But no fix was damaging only the community

@bigtreetech bigtreetech merged commit 65a8959 into bigtreetech:master Aug 24, 2023
@V1EngineeringInc
Copy link

Niiiice!!

@rondlh
Copy link

rondlh commented Aug 24, 2023

Merged 🥇 Great job, thanks for your support!

@V1EngineeringInc
Copy link

Thank you both for putting in the effort. This has been a bug for a very long time.

mattcoon pushed a commit to mattcoon/BIGTREETECH-TouchScreenFirmware that referenced this pull request Sep 22, 2023
* Fixed random pause/hesitation when printing

* added volatile type for wIndex on Serial.h

* minor cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Q] Random pauses or hesitation when printing.
4 participants