-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed random pause/hesitation when printing #2827
Conversation
How to get this PR merged asap? |
It seems to be enough to solve the issue (just keeping in this PR the minimal code). |
@digant73 Are you responding to me? If so then you seem to have misunderstood my question... |
I have also to work and travel during the day. If you are afraid about the possible issue due to no use of |
I mean this... many PRs have NOT been merged for a long time, perhaps BTT is not paying much attention, so the question is how do we get your recent work merged asap? I'm not worried about the volatile variable, it has been off during all of my testing. |
I can only suppose that some PRs are not merged for reasons that the author perfectly know. After that said, as far as I see BTT is OoO since more than 10 days. I already asked BTT to consider to merge many PRs if it can help. |
Niiiice!! |
Merged 🥇 Great job, thanks for your support! |
Thank you both for putting in the effort. This has been a bug for a very long time. |
* Fixed random pause/hesitation when printing * added volatile type for wIndex on Serial.h * minor cleanup
BUGFIXES:
Serial_Get
finction inSerialConnection
API improved to prevent the possibility to read multiple times the same partial message on next function invokation until the message if fully received from serial port. It also avoids to read multiple times the same partial message in case of failure on the serial connection (e.g. due to EMI)fixes #2761
PR STATE: Ready for merge