Compute color variables using relative color syntax #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using new lch(from) syntax
dz4k
changed the title
|
I hope to chime in more later, but for now I'll say that I like the idea of having a variable that determines the overall "colorfulness" of the page, something that is implemented akin to Perhaps something that could be implemented with adjectives such as "bright,", "vivid", "drab," "iridescent" etc (or any of the other Google search results for "adjectives describing color"). Although, while density is something most developers would want granular control over, perhaps "colorfulness" is more of a "one size fits all" once the value is set. |
|
Also, re: 2.0, if this PR does end up requiring a version increase, do you have a wishlist of components you'd like to see implemented in 2.0 as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relative color syntax is supported on every browser I personally care about (except Firefox Android), so this seems like a pretty good time to start experimenting.
In this PR, the whole color palette is derived from a single variable (
--base-accent).The PR changes the programmatic interface of missing.css, so we either need to find a way to not do that, or make a version 2.0.
Some considerations:
--bgand--fgare computed from the accent color, but the effect is basically imperceptible. Should we make it more or less prominent?info ok warn bad), the hue is currently not affected by the accent color (only lightness and chromaticity). Is there some color theory magic we can do to generate colorways that are harmonious with the accent, and also avoid clashes?--blue-10etc)? These were never documented and only meant for internal use, but some people might be depending on them.