Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render toast as aria-live region on page load #3112

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Render toast as aria-live region on page load #3112

merged 3 commits into from
Jan 8, 2025

Conversation

yawaramin
Copy link
Contributor

This tells the screen reader to announce updates that happen inside the span#toast element. Without this, the screen reader does not announce the notification message.

@yawaramin
Render toast as aria-live region on page load
ba534e1 
This tells the screen reader to announce updates that happen inside the
`span#toast` element.
@yawaramin
Update code sample in example text
c33536e
@yawaramin
Use <output> element to announce form action
3e17471
alexpetros
alexpetros approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@alexpetros alexpetros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yawar!

@alexpetros alexpetros merged commit 271a386 into bigskysoftware:master Jan 8, 2025
1 check passed
@yawaramin yawaramin deleted the aria-live branch January 8, 2025 04:34
oliverhaas pushed a commit to oliverhaas/htmx that referenced this pull request Jan 28, 2025
@yawaramin @oliverhaas
Render toast as aria-live region on page load (bigskysoftware#3112)
a2c1a17 
* Render toast as aria-live region on page load

This tells the screen reader to announce updates that happen inside the
`span#toast` element.

* Update code sample in example text

* Use <output> element to announce form action
emilhem pushed a commit to emilhem/htmx that referenced this pull request Feb 10, 2025
@yawaramin @emilhem
Render toast as aria-live region on page load (bigskysoftware#3112)
d49d5da 
* Render toast as aria-live region on page load

This tells the screen reader to announce updates that happen inside the
`span#toast` element.

* Update code sample in example text

* Use <output> element to announce form action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexpetros alexpetros alexpetros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yawaramin @alexpetros