Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Make htmx:beforeSwap more complete #3110

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

scrhartley
Copy link
Contributor

Description

Add descriptions for more properties: isError, serverResponse, selectOverride and swapOverride.
Add a note that modifying values for this event will override how htmx behaves, since this is by design.

Testing

Inspected with Zola and verified the links work

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@Telroshan Telroshan added the documentation Improvements or additions to documentation label Jan 8, 2025
@Telroshan Telroshan merged commit 9062996 into bigskysoftware:master Jan 8, 2025
1 check passed
oliverhaas pushed a commit to oliverhaas/htmx that referenced this pull request Jan 28, 2025
emilhem pushed a commit to emilhem/htmx that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants