Correct preload initialisation on forms with fieldsets (#150)

Fixes #149.
bigskysoftware · Mar 1, 2025 · f1e59ef · f1e59ef
1 parent d4e37d8
commit f1e59ef
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/src/preload/preload.js b/src/preload/preload.js
@@ -90,7 +90,9 @@
       for (let i = 0; i < form.elements.length; i++) {
         const element = form.elements.item(i);
         init(element);
-        element.labels.forEach(init);
+        if ("labels" in element) {
+          element.labels.forEach(init);
+        }
       }
       return
     }
@@ -385,4 +387,4 @@
     }
     return node instanceof HTMLSelectElement;
   }
-})()
+})()
diff --git a/src/preload/test/ext/forms.js b/src/preload/test/ext/forms.js
@@ -244,5 +244,21 @@ describe('preload extension preloads forms', function() {
 
       should.equal(requests.length, 1)
     })
+
+    it('skips label initialisation for fieldsets (issue 149)', function() {
+      const form = make(`
+        <form action="/test" method="get" preload>
+	  <fieldset>
+            <input type="text" name="name" value="John">
+	  </fieldset>
+          <input type="submit" value="Submit">
+        </form>
+      `)
+      const submitButton = form.querySelector("input[type='submit']")
+
+      htmx.trigger(submitButton, 'mousedown')
+
+      should.equal(requests.length, 1)
+      should.equal(requests[0].url, '/test?name=John')
+    })
   })
-