Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #914 (SympTEMIST) #915

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Closes #914 (SympTEMIST) #915

merged 4 commits into from
Jul 18, 2024

Conversation

phlobo
Copy link
Collaborator

@phlobo phlobo commented Mar 13, 2024

closes #914

Checkbox

  • Confirm that this PR is linked to the dataset issue.
  • Create the dataloader script hub/hub_repos/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
  • Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _BIGBIO_VERSION variables.
  • Implement _info(), _split_generators() and _generate_examples() in dataloader script.
  • Make sure that the BUILDER_CONFIGS class attribute is a list with at least one BigBioConfig for the source schema and one for a bigbio schema.
  • Confirm dataloader script works with datasets.load_dataset function.
  • Confirm that your dataloader script passes the test suite run with python -m tests.test_bigbio_hub <dataset_name> [--data_dir /path/to/local/data] --test_local.
  • If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

Copy link
Collaborator

@leonweber leonweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @phlobo. Could you please have a look at the comments?

bigbio/hub/hub_repos/symptemist/symptemist.py Outdated Show resolved Hide resolved
bigbio/hub/hub_repos/symptemist/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@leonweber leonweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarifications @phlobo. I have one more request regarding the license.

bigbio/hub/hub_repos/symptemist/README.md Outdated Show resolved Hide resolved
leonweber
leonweber previously approved these changes Jul 18, 2024
Copy link
Collaborator

@leonweber leonweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@leonweber leonweber merged commit 207a13a into bigscience-workshop:main Jul 18, 2024
phlobo added a commit to davidkartchner/biomedical that referenced this pull request Oct 21, 2024
* SympTEMIST dataloader

* Readme

* License shortcut

---------

Co-authored-by: Leon Weber-Genzel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SympTEMIST dataset
2 participants