Fix softmax #259
Closed
Fix softmax #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for detecting that we missed that upstream fix, @thomasw21. Since I originally applied the first batch of these fixes, I tried to see what else was missing and discovered a lot more of those and I'm trying a different approach here: #260 |
|
Thanks @stas00 I think we can merge these fixes on your branch if your prefer or master. (I think they are relevant and not covered by your PR) |
|
Yes, and there are more fixes in this file besides what you added - I'm checking what else might need to go in there and updating my PR. I'm going backwards - taking the Meg-LM version as master and checking if we made any changes to it and syncing those changes if need be. |
|
Closing in favor of #260 |
adammoody
pushed a commit
to adammoody/Megatron-DeepSpeed
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hyunwoongko has provided a fix for gpt-neox EleutherAI/gpt-neox#572. I think the same fix applies to us. I think this might have affect the throughput in some ways.
@hyunwoongko feel free to correct my if i'm wrong.