Use static_cast<int>.

bigladder · Jan 22, 2024 · 82e4d3b · 82e4d3b
1 parent 58a6704
commit 82e4d3b
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/HPWHHeatSources.cc b/src/HPWHHeatSources.cc
@@ -1029,11 +1029,11 @@ double HPWH::HeatSource::addHeatExternal(double externalT_C,
 
         // mix with node above from outlet to inlet
         // mix inlet water at target temperature with inlet node
-        for (std::size_t nodeIndex = externalOutletHeight; nodeIndex <= externalInletHeight;
+        for (std::size_t nodeIndex = externalOutletHeight; static_cast<int>(nodeIndex) <= externalInletHeight;
              ++nodeIndex)
         {
             double& mixT_C =
-                (nodeIndex == externalInletHeight) ? targetT_C : hpwh->tankTemps_C[nodeIndex + 1];
+                (static_cast<int>(nodeIndex) == externalInletHeight) ? targetT_C : hpwh->tankTemps_C[nodeIndex + 1];
             hpwh->tankTemps_C[nodeIndex] =
                 (1. - nodeFrac) * hpwh->tankTemps_C[nodeIndex] + nodeFrac * mixT_C;
         }
@@ -1153,11 +1153,11 @@ double HPWH::HeatSource::addHeatExternalMP(double externalT_C,
 
         // mix with node above from outlet to inlet
         // mix inlet water at target temperature with inlet node
-        for (std::size_t nodeIndex = externalOutletHeight; nodeIndex <= externalInletHeight;
+        for (std::size_t nodeIndex = externalOutletHeight; static_cast<int>(nodeIndex) <= externalInletHeight;
              ++nodeIndex)
         {
             double& mixT_C =
-                (nodeIndex == externalInletHeight) ? targetT_C : hpwh->tankTemps_C[nodeIndex + 1];
+                (static_cast<int>(nodeIndex) == externalInletHeight) ? targetT_C : hpwh->tankTemps_C[nodeIndex + 1];
             hpwh->tankTemps_C[nodeIndex] =
                 (1. - nodeFrac) * hpwh->tankTemps_C[nodeIndex] + nodeFrac * mixT_C;
         }