Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLATFORM-517: added timeouts #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

n1te1337
Copy link

ping @rayward @dsolsona @bigcommerce-labs/platform

@rayward
Copy link
Member

rayward commented Dec 22, 2016

Don't think this PR is necessary, you can configure default request options (such as the timeouts) on the guzzle client itself.

http://docs.guzzlephp.org/en/latest/quickstart.html#creating-a-client

@n1te1337
Copy link
Author

n1te1337 commented Dec 22, 2016

@rayward of course you can, but the question is whether the person using the client should know how to use/configure guzzle. If you follow this path you can just say that the whole client is unnecessary because all of the requests can be done with guzzle.

@rayward
Copy link
Member

rayward commented Dec 22, 2016

You'd expect them to know how to use it as it's a dependency of creating a Vault\Client.

If you follow this path you can just say that the whole client is unnecessary because all of the requests can be done with guzzle.

I wouldn't go that far, you're encapsulating how requests are sent and parsed specifically for vault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants