refactor(landing): replace landing by the subscription version #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 22027bf):
(expires Mon, 04 Mar 2024 21:50:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 0388d23e5b2fa83e6012d5f838e3ef96426e6354 |
bc-micah
force-pushed
the
refactor/landing
branch
from
e31c60a to
22027bf
Compare
bc-micah
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Replace
landingby the `subscription version.Current implementation has dirty copy/paste to win time for normal refactoring and make release faster.
What's done:
Difference between landing and subscription:
Why?
Fast release and win time for normal refactoring
Testing/Proof
Locally.