STRF-7438 fix stencil language translation in Safari #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-williamkwon
force-pushed
the
fixSafariTranslation
branch
2 times, most recently
from
8c8d9f4 to
18ed2ea
Compare
mattolson
suggested changes
Oct 17, 2019
bc-williamkwon
force-pushed
the
fixSafariTranslation
branch
8 times, most recently
from
7365a43 to
5c4b5e8
Compare
mattolson
suggested changes
Oct 18, 2019
bc-williamkwon
force-pushed
the
fixSafariTranslation
branch
from
5c4b5e8 to
796b2ab
Compare
mattolson
reviewed
Oct 18, 2019
lib/translator/locale-parser.js
Outdated
|
|
||
| // Safari sends only one language code, this is to have a default fallback in case we don't have that language | ||
| // As an example we may not have fr-FR so add fr to the header | ||
| if (localesArr.length === 1 && localesArr[0].split('-').length === 2) { |
There was a problem hiding this comment.
How does this work? I thought localesArr[0] would be an object, not a string.
There was a problem hiding this comment.
localesArr[0] would be an object after acceptlanguageparser.parse but I'm doing this after the map function which makes things into an array of strings.
bc-williamkwon
force-pushed
the
fixSafariTranslation
branch
from
796b2ab to
3cc2e3f
Compare
mattolson
approved these changes
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue of Safari only sending the most preferred language's code. If the most preferred language's code does not exist then we go to the fallback for that language such as fr-CA to fr. If neither of these locales exist then we fallback to English. Tested in safari browser.
https://jira.bigcommerce.com/browse/STRF-7438