Allow replace helper to accept safestrings, release 2.0.20

helpers/replace.js

@@ -1,7 +1,11 @@
 'use strict';
+const common = require('../lib/common.js');
 
 function helper(paper) {
     paper.handlebars.registerHelper('replace', function (needle, haystack) {
+        needle = common.unwrapIfSafeString(needle);
+        haystack = common.unwrapIfSafeString(haystack);
+
         const options = arguments[arguments.length - 1];
 
         if (typeof needle !== 'string') {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bigcommerce/stencil-paper",
-  "version": "2.0.23",
+  "version": "2.0.24",
   "description": "A stencil plugin to register partials and helpers from handlebars and returns the compiled version for the stencil platform.",
   "main": "index.js",
   "author": "Bigcommerce",

test/helpers/replace.js

@@ -14,6 +14,7 @@ describe('replace helper', function() {
     const context = {
         content: "Either you run the %%var%% or the  %%var%% runs you",
         price: '$49.99',
+        facet: 'brand',
     };
 
     it('should replace all ocurrance of %%var%% with "day"', function(done) {
@@ -45,6 +46,13 @@ describe('replace helper', function() {
         done();
     });
 
+    it('should work nicely with other helpers that use safestring', function(done) {
+        expect(c("Replace+Concat+Hyphenated: fifth-{{#replace '&' (concat '&' (hyphenate facet)) }}{{/replace}}", context))
+            .to.be.equal("Replace+Concat+Hyphenated: fifth-brand");
+
+        done();
+    });
+
     it('should gracefully handle not strings', function(done) {
         expect(c("{{#replace something price}}{{/replace}}", context))
             .to.be.equal('');