Update jsonParseSafe.js - Inline use patch #341
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add patch to allow for #JSONparseSafe to be used as a inline helper.
Examples:
{{log (JSONparseSafe '{"test":"variable"}')}}
{{log (lookup (JSONparseSafe '{"test":{"validate":"variable"}}') "test")}}
What? Why?
To prevent this situation which makes code so much harder to maintain and reason with:
This change removes a extra layer of context shifting
( ../ )
to access information about the context window.How was it tested?
Local tests, modified local theme testing file.
cc @bigcommerce/storefront-team