Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add implementation of javascript "typeof".
Implementation is based on json.js call which will yield a inline string as a result.
Registration into helpers list is required if approved. https://github.com/bigcommerce/paper-handlebars/blob/master/helpers.js
What? Why?
Function to determine type of provided input regardless of what the inline result is for use in if statements, and inline object construction. eg. of using in JSON.Parse string
{"value_type":"{{typeof variable}}"}
.This also has the side effect that it will prevent needed to serialise objects in no-js environments to determine flow state via CSS selectors.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/typeof
How was it tested?
Not tested. Based off existing file json.js with output line returning
typeof data
instead ofJSON.stringify(data)
.cc @bigcommerce/storefront-team