Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4] addition of non admin users privileges test #8

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

johnmunster
Copy link
Contributor

@johnmunster johnmunster commented Dec 1, 2023

Description

Test for #4 - This PR is for the addition of a test that ensures non admin users cannot see the release notes creation post type.

Change Log

  • RoleSeeder added to allow for the change of users roles before the test begins.
  • New test added that checks to see the editors cannot see the release notes creation post type
  • Refactored the existing Release Notes Creation test

Steps to test

  1. Checkout to the branch
  2. run npm run test:e2e to start up the docker container
  3. run npx cypress open to start up Cypress
  4. Choose End to End testing
  5. Run non admin users test

Screenshots/Videos

Video of passing test
http://bigbite.im/v/Crm68m

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@g-elwell g-elwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, loops over the user roles and asserts for each one. Slight typo but not a blocker for approval

cypress/e2e/non-admin-users.cy.js Outdated Show resolved Hide resolved
@johnmunster johnmunster merged commit 8947245 into main Dec 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants