Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MyMPD Service #1776

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Add MyMPD Service #1776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b763ba0
create mympd service
cadr10 Oct 23, 2024
a490b50
Create mympd config.json
cadr10 Oct 23, 2024
75bc3c1
Update config.json
cadr10 Dec 7, 2024
3b01985
Update docker-compose.yml
cadr10 Dec 7, 2024
7c49638
Update docker-compose.yml
cadr10 Dec 7, 2024
641da4b
Update docker-compose.yml
cadr10 Dec 7, 2024
9e17339
Update docker-compose.yml
cadr10 Dec 7, 2024
b0c3346
Update docker-compose.yml
cadr10 Dec 7, 2024
b5c9413
Update Apps/mympd/docker-compose.yml
cadr10 Dec 7, 2024
9fe0cb1
Update docker-compose.yml
cadr10 Dec 7, 2024
3113941
Update docker-compose.yml
cadr10 Dec 7, 2024
fb4d7db
Update docker-compose.yml
cadr10 Dec 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Apps/mympd/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"id": "mympd",
"version": "18.2.2",
"image": "ghcr.io/jcorporation/mympd/mympd",
"youtube": "",
"docs_link": "",
"big_bear_cosmos_youtube": ""
}
50 changes: 50 additions & 0 deletions Apps/mympd/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
name: big-bear-mympd # Name of the CasaOS application
services:
mympd:
cadr10 marked this conversation as resolved.
Show resolved Hide resolved
image: ghcr.io/jcorporation/mympd/mympd:18.2.2
container_name: big-bear-mympd
ports:
- ${MYMPD_HTTP_PORT:-8080}:8080
user: ${MYMPD_UID:-1000}:${MYMPD_GID:-1000}
environment:
- UMASK_SET=022
- MYMPD_SSL=false
- MYMPD_HTTP_PORT=${MYMPD_HTTP_PORT:-8080}
- MPD_HOST=${MPD_HOST:-localhost}
- MPD_PORT=${MPD_PORT:-6600}
- MYMPD_UID=1000
Comment on lines +9 to +15
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix inconsistent UID configuration.

There's an inconsistency in the UID configuration:

  • Line 8 uses parameterized ${MYMPD_UID:-1000}
  • Line 15 hardcodes MYMPD_UID=1000

This could lead to confusion and potential issues.

Remove the hardcoded MYMPD_UID:

    environment:
      - UMASK_SET=022
      - MYMPD_SSL=false
      - MYMPD_HTTP_PORT=${MYMPD_HTTP_PORT:-8080}
      - MPD_HOST=${MPD_HOST:-localhost}
      - MPD_PORT=${MPD_PORT:-6600}
-     - MYMPD_UID=1000
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
environment:
- UMASK_SET=022
- MYMPD_SSL=false
- MYMPD_HTTP_PORT=${MYMPD_HTTP_PORT:-8080}
- MPD_HOST=${MPD_HOST:-localhost}
- MPD_PORT=${MPD_PORT:-6600}
- MYMPD_UID=1000
environment:
- UMASK_SET=022
- MYMPD_SSL=false
- MYMPD_HTTP_PORT=${MYMPD_HTTP_PORT:-8080}
- MPD_HOST=${MPD_HOST:-localhost}
- MPD_PORT=${MPD_PORT:-6600}

volumes:
- /DATA/AppData/$AppID/run/mpd:/run/mpd
## Optional for myGPIOd support
## - /run/mygpiod:/run/mygpiod
- /DATA/AppData/$AppID/docker/mympd/workdir:/var/lib/mympd
- /DATA/AppData/$AppID/docker/mympd/cachedir:/var/cache/mympd
- /DATA/AppData/$AppID/var/lib/mpd/music:/var/lib/mpd/music:ro
- /DATA/AppData/$AppID/var/lib/mpd/playlists:/var/lib/mpd/playlists:ro
restart: unless-stopped

# Global CasaOS specific configuration
x-casaos:
architectures: # Supported CPU architectures for the application
- amd64
- arm64
- armv6
- armv7
main: big-bear-mympd # Specifies the main service of the application
description:
en_us: myMPD is a standalone and mobile friendly web-based MPD client with a tiny footprint and advanced features.
tagline:
en_us: mpd # Short description or tagline in English
developer: "jcorporation" # Developer's name or identifier (currently empty)
author: BigBearCommunity # Author of this Docker Compose configuration
icon: https://jcorporation.github.io/myMPD/assets/mympd-logo.svg # Icon URL for the application
thumbnail: "" # Thumbnail image URL
title:
en_us: mympd # Title in English
category: BigBearCasaOS # Category of the application
port_map: "8080" # Port mapping information for the service
scheme: http # Scheme for the service
tips:
before_install:
en_us: |
Check https://jcorporation.github.io/myMPD/010-installation/docker/#docker-compose and https://jcorporation.github.io/myMPD/020-configuration/configuration-files/ for more configuration.