Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify metadata.yml according to #99 and #103 #112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Modify metadata.yml according to #99 and #103 #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eye2bids/config/metadata.yml → eye2bids/config/eyelink_metadata.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@
SampleCoordinateUnits: str
SampleCoordinateSystem: str
EnvironmentCoordinates: str
ScreenDistance: int
ScreenDistance: float # or express as X,Y,Z coordinates, e.g. [0.05, 0.30, 0.40]
ScreenRefreshRate: int
ScreenSize: [float]

# Recommended (leave empty if not available but put information you want to share with your dataset here!):
SoftwareVersion: str
ScreenAOIDefinition: [str, [int]]
EyeCameraSettings:
EyeTrackerDistance: float
EyeTrackerDistance: float # or express as X,Y,Z coordinates, e.g. [0.05, 0.30, 0.40]
FeatureDetectionSettings:
GazeMappingSettings:
RawDataFilters:
Expand Down
2 changes: 1 addition & 1 deletion tests/data/metadata.yml → tests/data/eyelink_metadata.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
SampleCoordinateUnits: pixel
SampleCoordinateSystem: gaze-on-screen
EnvironmentCoordinates: top-left
ScreenDistance: 60
ScreenDistance: 0.6
ScreenRefreshRate: 60
ScreenSize: [0.386, 0.29]

Expand Down
2 changes: 1 addition & 1 deletion tests/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def root_dir() -> Path:
@pytest.mark.parametrize("output_dir", [data_dir() / "output", None])
@pytest.mark.parametrize("use_relative_path", [False, True])
def test_edf_cli(use_relative_path, output_dir, eyelink_test_data_dir):
metadata_file = data_dir() / "metadata.yml"
metadata_file = data_dir() / "eyelink_metadata.yml"

input_dir = eyelink_test_data_dir / "satf"
input_file = edf_test_files(input_dir=input_dir)[0]
Expand Down
8 changes: 4 additions & 4 deletions tests/test_edf2bids.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def _check_output_content(output_dir, input_file, eye=1):
@pytest.mark.skipif(not _check_edf2asc_present(), reason="edf2asc missing")
def test_edf_end_to_end_all(eyelink_test_data_dir, folder):
"""Run conversion of all test datasets and check output."""
metadata_file = data_dir() / "metadata.yml"
metadata_file = data_dir() / "eyelink_metadata.yml"

input_dir = eyelink_test_data_dir / folder
input_file = edf_test_files(input_dir=input_dir)[0]
Expand All @@ -111,7 +111,7 @@ def test_edf_end_to_end_all(eyelink_test_data_dir, folder):
@pytest.mark.skipif(not _check_edf2asc_present(), reason="edf2asc missing")
def test_edf_end_to_end_emg_xfail(eyelink_test_data_dir, folder):
"""Run conversion of all test datasets and check output."""
metadata_file = data_dir() / "metadata.yml"
metadata_file = data_dir() / "eyelink_metadata.yml"

input_dir = eyelink_test_data_dir / folder
input_file = edf_test_files(input_dir=input_dir)[0]
Expand All @@ -128,7 +128,7 @@ def test_edf_end_to_end_emg_xfail(eyelink_test_data_dir, folder):
@pytest.mark.xfail(reason="Output is not a continuous recording. See #69.")
@pytest.mark.skipif(not _check_edf2asc_present(), reason="edf2asc missing")
def test_edf_end_to_end(eyelink_test_data_dir):
metadata_file = data_dir() / "metadata.yml"
metadata_file = data_dir() / "eyelink_metadata.yml"

input_dir = eyelink_test_data_dir / "satf"
input_file = edf_test_files(input_dir=input_dir)[0]
Expand Down Expand Up @@ -175,7 +175,7 @@ def test_edf_end_to_end_error_no_metadata(eyelink_test_data_dir):

@pytest.mark.skipif(not _check_edf2asc_present(), reason="edf2asc missing")
def test_edf_end_to_end_2eyes(eyelink_test_data_dir):
metadata_file = data_dir() / "metadata.yml"
metadata_file = data_dir() / "eyelink_metadata.yml"

input_dir = eyelink_test_data_dir / "2eyes"
input_file = edf_test_files(input_dir=input_dir)[0]
Expand Down