Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to show a comprehensive HED example. #423

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

VisLab
Copy link
Member

@VisLab VisLab commented Jan 19, 2024

This commit adds a new eeg_ds003645s_hed_demo dataset, which demonstrates various uses of HED in a BIDS dataset. In addition to annotating the events.tsv files, the dataset demonstrates the use of HED to annotate participants.tsv, samples.tsv, scans.tsv, and phenotypes/*.tsv.

Validation of HED in these BIDS files is supported starting in hed-validator 3.13.3.

This example supersedes:

  • eeg_ds003645s_hed
  • eeg_ds003645s_hed_inheritance
  • eeg_ds003645s_hed_longform,

all of which have now been removed. @sappelhoff this the consolidation of HED examples as mentioned previously.

@VisLab
Copy link
Member Author

VisLab commented Jan 24, 2024

@rwblair @sappelhoff:

I believe that the error in this is incorrect handling by the BIDS validator. The phenotypes does not validate if there is more than one entry for a subject (which I think it should allow according to the spec). Further, when there is more than one .tsv file in the phenotypes subdirectory, the dataset won't validate. (I gave in and took out multiple .tsv's for the example, but I think this is also an error.) Thx!
issueWithPhenotypevalidation

@sappelhoff
Copy link
Member

Is this the issue you reported in

?

@VisLab
Copy link
Member Author

VisLab commented Jan 24, 2024

Is this the issue you reported in

* [phenotype doesn't appear to allow more than one assessment. bids-validator#1874](https://github.com/bids-standard/bids-validator/issues/1874)

?

This is related, but an additional issue. I guess I will put an addendum on issue #1874. This issue is that when the dataset has sessions, multiple entries in a phenotype/*.tsv for the same subject in a phenotype file won't validate. It has nothing to do with HED. I'll remove the multiple entry on this example or the entire phenotype file if necessary to move this example forward. Thx

Copy link
Contributor

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is good to merge, pending a validator release?

@VisLab
Copy link
Member Author

VisLab commented Jan 24, 2024

Yes...we think it is good to go...

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 once CIs are passing

@VisLab
Copy link
Member Author

VisLab commented Feb 23, 2024

hed-javascript version 3.13.3 was merged with bids-validator master on January 24, 2024. It fixes the issues that caused this example not to validate.

@rwblair rwblair merged commit 0d60f73 into bids-standard:master Feb 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants