Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New appendix page: spherical harmonics #104

Open
wants to merge 2 commits into
base: bep-016
Choose a base branch
from
Open

Conversation

Lestropie
Copy link
Collaborator

Closes #100.

I'm not 100% happy with the structure: there's a section on "truncated spherical harmonics", and there there are tables relating maximal spherical harmonic degree to number of coefficients, yet the former don't reside in the latter. But they can't just be moved because of other order dependencies.

Copy link
Collaborator

@arokem arokem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the order issue, maybe add a "see below in XXX"?

src/appendices/spherical-harmonics.md Outdated Show resolved Hide resolved
src/appendices/spherical-harmonics.md Outdated Show resolved Hide resolved

![SH functions](https://latex.codecogs.com/gif.latex?Y_l^m(\theta,\phi)&space;=&space;\sqrt{\frac{(2l+1)}{4\pi}\frac{(l-m)!}{(l+m)!}}&space;P_l^m(\cos&space;\theta)&space;e^{im\phi}")

for integer *order* *l*, *phase* *m*, associated Legendre polynomials *P*.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider "phase factor" instead of "phase"? See dipy/dipy#3086 (comment) and preceding discussing there.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lately I've tried to consistently use "degree" rather than "order" for l. Wikipedia uses "degree" and "order". "Phase factor" is at risk of erroneous conflation with specifically the Condon-Shortley phase factor. So I wonder if adopting "degree" and "order" here would be better?
(I'd likely modify the MRtrix3 online documentation accordingly)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really prefer to use "order" here (rather than "degree") for the reasons mentioned in that PR discussion in DIPY (i.e., to be consistent with the dMRI literature). But I agree that "phase" is fine, even though it implies something continuous, it is easy to understand what it means.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdtournier any strong opinions? I have some limited sense that we've tried to transition to "degree" for l, but our own SH docs page conflicts, other docs self-conflict, and I'm not able to find any discussions online.

PS. This terminology is not just for the appendix, there's also a metadata field specifying maximal l. Could call it "SphericalHarmonicLmax" or the like if there's too much contention.

src/appendices/spherical-harmonics.md Show resolved Hide resolved
src/appendices/spherical-harmonics.md Show resolved Hide resolved
@Lestropie
Copy link
Collaborator Author

Excess """ characters at ends of equations were in the code prior to this review, so some copy-and-paste error was made upstream.

@arokem
Copy link
Collaborator

arokem commented May 18, 2024

Excess """ characters at ends of equations were in the code prior to this review, so some copy-and-paste error was made upstream.

That's probably something I did 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move spherical harmonics to its own Appendix
2 participants