Repaired Fatal Error for Nonexistent URLs

[Windows81]

For playlists which contain nonexistent videos, entries may return as None. In that case, the program will print this stack trace:

An exception just occured, if you found this exception isn't related with any of your connection problem, please report this issue to https://github.com/bibanon/tubeup/issues
Traceback (most recent call last):
  File "C:\Users\USERNAME\AppData\Roaming\Python\Python311\site-packages\tubeup\__main__.py", line 99, in main
    for identifier, meta in tu.archive_urls(URLs, metadata,
  File "C:\Users\USERNAME\AppData\Roaming\Python\Python311\site-packages\tubeup\TubeUp.py", line 417, in archive_urls
    downloaded_file_basenames = self.get_resource_basenames(
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\USERNAME\AppData\Roaming\Python\Python311\site-packages\tubeup\TubeUp.py", line 176, in get_resource_basenames
    if check_if_ia_item_exists(entry) == 0:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\USERNAME\AppData\Roaming\Python\Python311\site-packages\tubeup\TubeUp.py", line 111, in check_if_ia_item_exists
    itemname = sanitize_identifier('%s-%s' % (infodict['extractor'],
                                              ~~~~~~~~^^^^^^^^^^^^^
TypeError: 'NoneType' object is not subscriptable

Tested on this playlist, which has one unavailable video.

[mrpapersonic]

The change at line 184 breaks regular (non-playlist) downloads.

Also, you think you could log a warning to the user instead of just silently not mirroring a video? e.g. [WARN] Video <url> is not available. Skipping.

[vxbinaca]

For playlists which contain nonexistent videos

It's your job to check URLs are alive. When you rip channels or playlists you do it at your own risk. Use yt-dlp to print out video IDs, pipe into batch file, rip one by one from batch. We can't do everything for you. Trying to do everything for the user increases the devs burden, increases the size of the codebase, and every attempt to do something a user thinks is a good idea leads to code breakage. I'm thinking of comments ripping.

Look into yt-dlps flags.

Not closing this in case you can make it work.

[Windows81]

Hey. Apologies for the bad commit, and thanks for running the tests! I'll take better care for the unit tests next time. I believe that the two lines I've added in, as insignificant as they are to the codebase, are worth the change for streamlining working on larger playlists.

[Windows81]

I just released a new commit and made sure that all 20 unit tests came out fine. I removed some redundant code and abstracted that away into a function for your convenience.

[brandongalbraith]

@Windows81 Haven't had a chance to review yet, but wanted to say thank you for putting the effort into resolving this edge case 👏🏻 🙇‍♂️

[Windows81]

You're welcome! It's not really an edge case when you're working with large playlists from channels which have had videos removed (which is almost every one).

[vxbinaca]

Thanks @Windows81 new version cut

[Windows81]

Hey. I tested it a bit more and made a new pull request for that.